From adf858879e590112741702e271eb9082b50c6da7 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Fri, 8 Apr 2016 18:13:38 +0200 Subject: [PATCH] libxl: only allow guests with a device model to use cd-{eject/insert} MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Roger Pau Monné Acked-by: Wei Liu --- tools/libxl/libxl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 91a1dd1384..d232473523 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -2913,6 +2913,12 @@ int libxl_cdrom_insert(libxl_ctx *ctx, uint32_t domid, libxl_device_disk *disk, goto out; } + if (dm_ver == LIBXL_DEVICE_MODEL_VERSION_NONE) { + LOG(ERROR, "Guests without a device model cannot use cd-insert"); + rc = ERROR_FAIL; + goto out; + } + disks = libxl_device_disk_list(ctx, domid, &num); for (i = 0; i < num; i++) { if (disks[i].is_cdrom && !strcmp(disk->vdev, disks[i].vdev)) -- 2.30.2